Issue #89 Call _brs_.resetMocks in between test files #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkipke
suggested changes
Apr 19, 2021
| @@ -38,6 +38,8 @@ export class TestRunner { | |||
| testFiles: string[] | |||
| ) { | |||
| testFiles.forEach((filename, index) => { | |||
| // Don't allow test files to pollute each other | |||
| _brs_.resetMocks(); | |||
There was a problem hiding this comment.
I don't think this will quite work -- _brs_ is only defined in Brightscript files, not Typescript, which is why we have compilation errors from Github Actions. I think we'll probably have to expose resetMocks as an export in the brs project, then call it from here.
| @@ -1,8 +1,12252 @@ | |||
| { | |||
| "name": "@hulu/roca", | |||
| "version": "0.21.0", | |||
| "lockfileVersion": 1, | |||
There was a problem hiding this comment.
Careful, we don't want to upgrade our lockfile version as part of this PR. We could do it separately (or better yet, switch to Yarn), but we should keep it as-is for this PR.
There was a problem hiding this comment.
Agree with Levi, on a side note we had some dependencies issues with npm7 and this change might break things
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #89 added
_brs_resetMocks()function toTestRunner.tsfile.