Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messages translatability #41

Closed
Menelion opened this issue May 19, 2016 · 2 comments
Closed

Messages translatability #41

Menelion opened this issue May 19, 2016 · 2 comments

Comments

@Menelion
Copy link

Hello,
First of all, thanks for your work. Nice to have a solution where accessibility is a key parameter.
I've started implementing Modaal on my website where the main language is Russian. And I found that the system messages like "Close" on the Close button seem not to be translatable. Ideally, this should be localizable at least in the configuration.
Any help would be highly appreciated. I could accomplish most of the work myself and send you a pull request, but first of all I would like to know how you want to proceed with it.
Thanks!

@danhumaan
Copy link
Collaborator

Hi @Oire, thanks for raising this task. We've completed an update that allows for customisation of the close text and close aria label attributes seen in the below options.

$('.my-modaal').modaal({
    close_text: 'Close',
    close_aria_label: 'Close (Press escape to close)'
});

The values seen above are the default. These options only need to be defined if you wish to change those values.

This update will be available in the next milestone release for v0.3.1 soon.

Thanks,
Dan

@danhumaan danhumaan mentioned this issue Jul 25, 2016
@danhumaan
Copy link
Collaborator

Thanks again, this is now available in the latest release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants