Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Instagram - Uncaught TypeError: Cannot read property 'Embeds' of undefined #72

Closed
paulburgess opened this issue Oct 12, 2016 · 4 comments

Comments

@paulburgess
Copy link

Using the modaal for showing instagram popups, everything still works but this error appears in the console: Uncaught TypeError: Cannot read property 'Embeds' of undefined

Refers to line 151:
window.instgrm.Embeds.process())

I think :-)

@danhumaan
Copy link
Collaborator

Good pickup, thanks for flagging this @paulburgess - is this stopping your instance from working? For me it's still working, but I can see the error. Worth investigating, but just trying to determine how much of a prioty this issue is, ie: it's stopping things working vs, it works but throws and error.

@danhumaan danhumaan added the bug label Oct 13, 2016
@paulburgess
Copy link
Author

paulburgess commented Oct 13, 2016

It all seems to works fine. I tried an older version as well and the issue was there too. But you know how it is... that red text staring at you from Developer Tools.

@danhumaan
Copy link
Collaborator

Ok no worries, thanks @paulburgess - we'll investigate and see what we can do.

@danhumaan
Copy link
Collaborator

hey @paulburgess, thanks again for raising the issue. I've worked in a fix and pushed it through to our develop branch. Will roll out a new milestone release soon that will have this included.

Leaving this open until we roll out the release, will close it then. Thanks

@danhumaan danhumaan self-assigned this Oct 17, 2016
mckelvaney pushed a commit to mckelvaney/Modaal that referenced this issue Mar 10, 2018
@danhumaan danhumaan modified the milestones: v0.3.2, v0.4.0 May 28, 2018
@danhumaan danhumaan mentioned this issue May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants