Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE8: L.DataLayer numberOfSides VML render #14

Closed
Xal3ph opened this issue Jan 16, 2014 · 4 comments
Closed

IE8: L.DataLayer numberOfSides VML render #14

Xal3ph opened this issue Jan 16, 2014 · 4 comments

Comments

@Xal3ph
Copy link

Xal3ph commented Jan 16, 2014

I'm getting some success with IE8 compatibility. However, the markers don't seem to even show unless the number of sides exceed a large number for L.DataLayer. If it's greater than like 30 or so, the marker will show. I need to use a square for a shape, this is causing a problem.

{
    displayName: ' ',
    displayText: function(){ return ' '; },
    numberOfSides: function(v){ return (v==1)?50:4;},//new L.LinearFunction(new L.Point(0,4),new L.Point(1,50)),
    color: function(v){ return (v==1)?"#FFFF00":"#4afc0c";},//ColorFunction,
    fillColor: function(v){ return (v==1)?"#FFFF00":"#4afc0c";},//FillColorFunction,
    rotation: 45
}
@sfairgrieve
Copy link
Contributor

Thanks for pointing this out. I'll do some testing to see what's going on. The DataLayer will use an L.CircleMarker rather than an L.RegularPolygonMarker when the number of sides is 30 or greater, so that explains why that's working.

@sfairgrieve
Copy link
Contributor

I just pushed a potential fix for this, but I'm still working on a good way to test it. I need to download a VM with IE8. In the meantime, can you pull the latest and see if that fixes anything?

@Xal3ph
Copy link
Author

Xal3ph commented Jan 17, 2014

This did fix the issue. Thank you for the quick resolution!

@Xal3ph Xal3ph closed this as completed Jan 17, 2014
@sfairgrieve
Copy link
Contributor

Great, glad it worked! When you get a chance, do you mind sharing which Leaflet DVF file you're importing? Are you using Leaflet 0.7 or an older version? The reason I ask is that another user is having trouble getting things working in IE 8 (see #10), even with the latest fix, so I'm trying to figure out what's going on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants