Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force the nextrun calculation to use UTC to be consistent with the DB #64

Merged
merged 5 commits into from
Sep 18, 2020

Conversation

discoinfiltrator
Copy link
Contributor

@discoinfiltrator
Copy link
Contributor Author

The phpcs violations are not from the file that I modified.

@mackensen
Copy link

This fix resolved the DST scheduling issue in our environment.

@discoinfiltrator
Copy link
Contributor Author

@rmccue can this be looked at so people aren't scrambling when this comes up again in the fall?

@discoinfiltrator
Copy link
Contributor Author

@rmccue @kadamwhite @missjwo what are the next steps to getting this merged? The DST switchover will be happening soon and it would be amazing to prevent this pretty brutal bug from happening to people.

Copy link
Contributor

@roborourke roborourke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the code here is good. We haven't run into this issue due to setting our server time to UTC but obviously that's not always something that everyone can or should change.

I need to create a tag of the current version first, then we can merge this in and test it out without potentially affecting production instances.

inc/class-job.php Outdated Show resolved Hide resolved
@discoinfiltrator
Copy link
Contributor Author

I also 100% agree that the DB, OS, PHP, etc should be using UTC - but sometimes you inherit large systems that are working with their current setup and it'd be tough to change 🙃. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants