Add WordPress plugin comment header #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmccue
requested changes
Jul 29, 2017
plugin.php
Outdated
| * Cavalcade! | ||
| * Plugin Name: Cavalcade | ||
| * Plugin URI: https://github.com/humanmade/Cavalcade | ||
| * Description: Scalable job system, designed as a drop-in replacement for wp_cron |
There was a problem hiding this comment.
Should copy from the existing description:
A better wp-cron. Horizontally scalable, works perfectly with multisite.
plugin.php
Outdated
| * Plugin Name: Cavalcade | ||
| * Plugin URI: https://github.com/humanmade/Cavalcade | ||
| * Description: Scalable job system, designed as a drop-in replacement for wp_cron | ||
| * Version: 0.1 |
There was a problem hiding this comment.
Unless it's required, I'd rather leave off the version until we start versioning Cavalcade.
There was a problem hiding this comment.
I'll check if it works even without the version. I'll use dev-master if it's mandatory.
|
Yes it worked just fine without |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The readme says that in order to use this plugin I need to add extra
mu-plugins/cavalcade.php.I usually have so many mu-plugins that this practice gets really hard to maintain and normally I don't add extra includes for each mu-plugin but instead I use bedrock-autoloader.php.
This can load all plugins from subfolders inside mu-plugins folder. But the problem here is that it doesn't work if the plugin in subfolder doesn't have correct comment headers in the start of the file.
This pull request fixes this problem and allows installation into subfolder without extra steps.
More info: https://roots.io/bedrock/docs/mu-plugins-autoloader/