Add job id constant for hooks #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmccue
approved these changes
Dec 13, 2017
There was a problem hiding this comment.
👍 Looks good to me.
Do you think there's also a use case for firing an action before (and maybe after) the job runs with the ID for logging/error handling? I'm thinking handling it at the meta level may be better than building into the job necessarily. (The constant is still useful for other use cases though.)
|
@rmccue good idea, so If your happy with this pr, ready to merge? |
Yep (and feel free to merge stuff that has an approved review; I only left it unmerged in case the action negated the need for this entirely). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently theres no way to obtain the job id from within a method being run as a Cavalcade job. This adds the
CAVALCADE_JOB_IDconstant allowing access to the current job.