Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include interval in realkey to allow for changed schedules. #65

Merged
merged 6 commits into from
Oct 23, 2018

Conversation

peterwilsoncc
Copy link
Contributor

@peterwilsoncc peterwilsoncc commented Aug 26, 2018

Includes the interval when generating keys for comparing old and new values of the cron array so events with a changed recurrence are re-saved.

In the database, this deletes the old job and then saves the event with a new ID. I considered using array_intersect_key() and looping through the result to see if any intervals had changed but decided this would probably be a bigger perf hit on large tables than the extra database write. Did I test this theory? No.

See #64

@rmccue
Copy link
Member

rmccue commented Oct 23, 2018

How does this work back-compat wise? Seems like it would potentially break a lot of stuff relying on the cron array.

@peterwilsoncc
Copy link
Contributor Author

peterwilsoncc commented Oct 23, 2018 via email

@peterwilsoncc
Copy link
Contributor Author

Bug reverted in 84f153b and actual intention carried out in c578579.

@rmccue rmccue merged commit 907c2ec into master Oct 23, 2018
@rmccue rmccue deleted the 64-fix-rescheduling branch October 23, 2018 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants