Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use WordPress default charset collate instead of database server #87

Merged
merged 2 commits into from
Nov 4, 2019
Merged

Use WordPress default charset collate instead of database server #87

merged 2 commits into from
Nov 4, 2019

Conversation

faishal
Copy link
Contributor

@faishal faishal commented Nov 1, 2019

Currently, Cavalcade is not defining any charset collate for its custom tables and it is creating a table with database server default.

hm-linter[bot]
hm-linter bot suggested changes Nov 1, 2019
View reviewed changes
Copy link

@hm-linter hm-linter bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linting failed (35 errors, 1 warning).

(34 notices occurred in your codebase, but were on files/lines not included in this PR.)

roborourke
roborourke reviewed Nov 4, 2019
View reviewed changes
inc/namespace.php Outdated Show resolved Hide resolved
roborourke
roborourke approved these changes Nov 4, 2019
View reviewed changes
Copy link
Contributor

@roborourke roborourke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a bonus space to remove but this looks good to me. We should look into a db upgrade routine for this as well but can do that in another PR.

@rmccue @roborourke
Remove bonus space
758b092 
No free spaces for you.

Co-Authored-By: Robert O'Rourke <robert@o-rourke.org>
@rmccue rmccue merged commit 87cae62 into master Nov 4, 2019
@rmccue rmccue deleted the use-default-charset-collate branch November 4, 2019 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hm-linter hm-linter[bot] hm-linter requested changes

@roborourke roborourke roborourke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@faishal @roborourke @rmccue