Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Travis tests #90

Merged
merged 8 commits into from
Jan 16, 2020
Merged

Fix Travis tests #90

merged 8 commits into from
Jan 16, 2020

Conversation

roborourke
Copy link
Contributor

An update to Travis meant we need to specify mysql under the services property now. This should fix the builds.

An update to Travis meant we need to specify mysql under the `services` property now. This should fix the builds.
Copy link

@hm-linter hm-linter bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linting failed (34 errors, 1 warning).

35 notices occurred in your codebase, but none on files/lines included in this PR.

@roborourke
Copy link
Contributor Author

So the tests are running again but with failures, was that the case before?

@roborourke
Copy link
Contributor Author

1) Tests_Cron::test_schedule_event_single
Failed asserting that false is true.
/home/travis/build/humanmade/Cavalcade/tests/class-wp-core-cron.php:45
2) Tests_Cron::test_schedule_event_single_args
Failed asserting that false is true.
/home/travis/build/humanmade/Cavalcade/tests/class-wp-core-cron.php:60
3) Tests_Cron::test_schedule_event
Failed asserting that false is true.
/home/travis/build/humanmade/Cavalcade/tests/class-wp-core-cron.php:78
4) Tests_Cron::test_schedule_event_args
Failed asserting that false is true.
/home/travis/build/humanmade/Cavalcade/tests/class-wp-core-cron.php:93
5) Tests_Cron::test_unschedule_event
Failed asserting that false is true.
/home/travis/build/humanmade/Cavalcade/tests/class-wp-core-cron.php:114
6) Tests_Cron::test_clear_schedule
Failed asserting that false is identical to 2.
/home/travis/build/humanmade/Cavalcade/tests/class-wp-core-cron.php:134
7) Tests_Cron::test_unschedule_hook
Failed asserting that false is identical to 4.
/home/travis/build/humanmade/Cavalcade/tests/class-wp-core-cron.php:240
8) Tests_Cron::test_duplicate_event
Failed asserting that false is true.
/home/travis/build/humanmade/Cavalcade/tests/class-wp-core-cron.php:273
9) Tests_Cron::test_not_duplicate_event
Failed asserting that false is true.
/home/travis/build/humanmade/Cavalcade/tests/class-wp-core-cron.php:292
10) Tests_Cron::test_not_duplicate_event_reversed
Failed asserting that false is true.
/home/travis/build/humanmade/Cavalcade/tests/class-wp-core-cron.php:311
11) Tests_Cron::test_pre_reschedule_event_filter
Failed asserting that false is true.
/home/travis/build/humanmade/Cavalcade/tests/class-wp-core-cron.php:385
12) Tests_Cron::test_pre_unschedule_event_filter
Failed asserting that false is true.
/home/travis/build/humanmade/Cavalcade/tests/class-wp-core-cron.php:409
13) Tests_Cron::test_pre_clear_scheduled_hook_filters
Failed asserting that false is true.
/home/travis/build/humanmade/Cavalcade/tests/class-wp-core-cron.php:433
14) Tests_Cron::test_duplicate_past_event
Failed asserting that false is true.
/home/travis/build/humanmade/Cavalcade/tests/class-wp-core-cron.php:613
15) Tests_Cron::test_duplicate_near_future_event
Failed asserting that false is true.
/home/travis/build/humanmade/Cavalcade/tests/class-wp-core-cron.php:635
16) Tests_Cron::test_duplicate_future_event
Failed asserting that false is true.
/home/travis/build/humanmade/Cavalcade/tests/class-wp-core-cron.php:657
17) Tests_Cron::test_not_duplicate_future_event
Failed asserting that false is true.
/home/travis/build/humanmade/Cavalcade/tests/class-wp-core-cron.php:677

@roborourke roborourke changed the title Add MySQL service Add MySQL service to Travis Jan 14, 2020
@roborourke
Copy link
Contributor Author

@rmccue maybe the core update_option() function changed but basically the core cron tests never pass as Cavalcade intentionally short circuits saving to the db, this means update_option() returns false and a bunch of asserts fail, there's no way around it. Think we need to remove them.

@roborourke roborourke changed the title Add MySQL service to Travis Fix Travis tests Jan 16, 2020
@roborourke
Copy link
Contributor Author

Core tests won't pass until #75 is merged, so this at least gets them to the point of running phpunit again with the right version

Copy link
Member

@rmccue rmccue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 thanks Rob!

We might want to pin the hm-linter version as well to get rid of those linter errors in a separate PR.

@rmccue rmccue merged commit 7fe50d1 into master Jan 16, 2020
@rmccue rmccue deleted the travis-add-mysql branch January 16, 2020 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants