-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Travis tests #90
Fix Travis tests #90
Conversation
An update to Travis meant we need to specify mysql under the `services` property now. This should fix the builds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linting failed (34 errors, 1 warning).
35 notices occurred in your codebase, but none on files/lines included in this PR.
So the tests are running again but with failures, was that the case before? |
|
@rmccue maybe the core |
Core tests won't pass until #75 is merged, so this at least gets them to the point of running phpunit again with the right version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌 thanks Rob!
We might want to pin the hm-linter version as well to get rid of those linter errors in a separate PR.
An update to Travis meant we need to specify mysql under the
services
property now. This should fix the builds.