Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add contribution guidelines #46

Merged
merged 4 commits into from Oct 4, 2019
Merged

Add contribution guidelines #46

merged 4 commits into from Oct 4, 2019

Conversation

roborourke
Copy link
Contributor

Instructions on how builds & releases work plus local set up instructions.

@roborourke roborourke requested a review from rmccue May 28, 2019 16:38
@roborourke roborourke changed the title Create CONTRIBUTING.md Add contribution guidelines May 28, 2019
@goldenapples goldenapples mentioned this pull request Oct 3, 2019
Merged
goldenapples
goldenapples approved these changes Oct 4, 2019
View reviewed changes
Copy link
Contributor

@goldenapples goldenapples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the last two steps in the Getting Started section to reflect the new package.json and build script. Looks good!

@goldenapples goldenapples merged commit ef659f4 into master Oct 4, 2019
@goldenapples goldenapples deleted the contributing-docs branch October 4, 2019 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goldenapples goldenapples goldenapples approved these changes

@rmccue rmccue Awaiting requested review from rmccue

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@roborourke @goldenapples