This repository has been archived by the owner on Oct 13, 2020. It is now read-only.
Update wpthumb.background-fill.php #89
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
| @@ -73,7 +73,7 @@ private function fill_color( array $colors ) { | |||
|
|
|||
| } elseif ( $current_size['height'] != $size['height'] ) { | |||
|
|
|||
| $colorToPaint = imagecolorallocatealpha( $new_image, substr( $colors['top'], 0, 3 ), substr( $colors['top'], 3, 3 ), substr( $colors['top'], 6, 3 ), substr( $colors['left'], 9, 3 ) ); | |||
| $colorToPaint = imagecolorallocatealpha( $new_image, substr( $colors['top'], 0, 3 ) + 0, substr( $colors['top'], 3, 3 ) + 0, substr( $colors['top'], 6, 3 ) + 0, substr( $colors['left'], 9, 3 ) + 0 ); | |||
There was a problem hiding this comment.
Seems like a more explicit solution here would be to just cast the substr return values directly to a float. Something like
$colorToPaint = imagecolorallocatealpha( $new_image, (float) substr( $colors['top'], 0, 3 ), (float) substr( $colors['top'], 3, 3 ), (float) substr( $colors['top'], 6, 3 ), (float) substr( $colors['left'], 9, 3 ) );
There was a problem hiding this comment.
This should be an int, but yes, should be cast rather than adding 0 to make it an int
|
This also ails 4 unit tests. If you wan to get the test running locally to find out why they are failing that would be great. However, it might be a bug in the tests |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix warnings in PHP