Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update v16.1 #848

Merged
merged 18 commits into from
Feb 8, 2024
Merged

Update v16.1 #848

merged 18 commits into from
Feb 8, 2024

Conversation

mikelittle
Copy link
Contributor

@mikelittle mikelittle commented Feb 8, 2024

V16.1 branch catchup to v16 branch.

Addresses https://github.com/humanmade/product-dev/issues/1518

mikelittle and others added 18 commits August 23, 2023 16:34
[Backport v16-branch] Fix image paths in DNS configuration page
Updates the requirements on [humanmade/batcache](https://github.com/humanmade/batcache) to permit the latest version.
- [Release notes](https://github.com/humanmade/batcache/releases)
- [Commits](humanmade/batcache@1.5.1...1.5.2)

---
updated-dependencies:
- dependency-name: humanmade/batcache
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Updates the requirements on [humanmade/aws-xray](https://github.com/humanmade/aws-xray) to permit the latest version.
- [Release notes](https://github.com/humanmade/aws-xray/releases)
- [Changelog](https://github.com/humanmade/aws-xray/blob/master/CHANGELOG.md)
- [Commits](humanmade/aws-xray@1.3.3...1.3.4)

---
updated-dependencies:
- dependency-name: humanmade/aws-xray
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Reformatted file to standards.
[Backport v16-branch] Add instruction to enable Afterburner
…/humanmade/aws-xray-approx-1.3.4

Update humanmade/aws-xray requirement from ~1.3.3 to ~1.3.4
…/humanmade/batcache-approx-1.5.2

Update humanmade/batcache requirement from ~1.5.1 to ~1.5.2
Updates the requirements on [humanmade/wp-redis-predis-client](https://github.com/humanmade/wp-redis-predis-client) to permit the latest version.
- [Release notes](https://github.com/humanmade/wp-redis-predis-client/releases)
- [Commits](humanmade/wp-redis-predis-client@0.1.0...0.1.1)

---
updated-dependencies:
- dependency-name: humanmade/wp-redis-predis-client
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
We recently enabled `opcache.enable_cli` so Cavalcade Runner now has the opcache enabled. This is a bug, it turns out in the opcache whereby including files over and over again will lead to a memory leak. See php/php-src#9812 for details.

This bug causes a very large memory leak in Cavalcade Runner because we naively re-init the Cloudwatchclient on every call to put_metric_data() etc.

So, it makes sense to only create the cloudwatch client once. THis should also drastically reduce the impact of the PHP bug.
[Backport v16-branch] Fix cavalcade runner memory usage leak
…/humanmade/wp-redis-predis-client-0.1.1

Update humanmade/wp-redis-predis-client requirement from 0.1.0 to 0.1.1
CloudFront will return an error from `createInvalidation` if the URL is not encoded. `tachyon_url()` already does this internally, so is not an issue on the tachyon_url.
Co-authored-by: Ryan McCue <me@ryanmccue.info>
[Backport v16-branch] URL encode filenames in CDN Media Purge
@mikelittle mikelittle merged commit 94ef60b into master Feb 8, 2024
3 of 4 checks passed
@mikelittle mikelittle deleted the update-v16.1 branch February 8, 2024 15:09
@hm-backport
Copy link

hm-backport bot commented Feb 8, 2024

The backport to v16.1-branch failed:

Commits ["db0b4def262fe6a37f646550ad06c7d5d7467d99","82016b65248807f08686de9c077c013a96ad5047","59be3df39ef0fd045a32a874a5f525f090ab63c5","2e84369c435a25740ee54c982f52bf7f2d1be37b","08841b414f3ed4d45b365eb2a67dbba3ad35e7c5","b212ba2b91b378ddacf713fdba6160a0a1f4bdea","b4307b8920514943755ca1b13695bbda4aef87f7","8b386c2401437a20cf799ec7d9437900b4af144a","3822765d757aa612cb32e9ae4c17783f36355e83","f84c35723cdd817b757df3a381c946d261e0be4d","a7ab212f329b33e9f112f803ea9805633fefe0e4","3c27deaeedf46098d86cb3f13e002dae93c237c9","44acd648920bfec9ced324b42b536402f8ea18cd","881e84d732c507992a65b6506015ee2dc5920f6c","63d128d26a251b252b7e6885b8f20f71f4b114c3","e978715cbf44b6d5b8c37cc4bdb411c9ccde47f0","60da302c59f41a857d6d365ce4fe04165509b042","6fdb86d5f3cc364f325f3ec2ae7b8aa6d9e31aed"] could not be cherry-picked on top of v16.1-branch

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub.
git fetch
# Create new working tree.
git worktree add .worktrees/backport v16.1-branch
# Navigate to the new directory.
cd .worktrees/backport
# Cherry-pick all the commits of this pull request and resolve the likely conflicts.
git cherry-pick db0b4def262fe6a37f646550ad06c7d5d7467d99 82016b65248807f08686de9c077c013a96ad5047 59be3df39ef0fd045a32a874a5f525f090ab63c5 2e84369c435a25740ee54c982f52bf7f2d1be37b 08841b414f3ed4d45b365eb2a67dbba3ad35e7c5 b212ba2b91b378ddacf713fdba6160a0a1f4bdea b4307b8920514943755ca1b13695bbda4aef87f7 8b386c2401437a20cf799ec7d9437900b4af144a 3822765d757aa612cb32e9ae4c17783f36355e83 f84c35723cdd817b757df3a381c946d261e0be4d a7ab212f329b33e9f112f803ea9805633fefe0e4 3c27deaeedf46098d86cb3f13e002dae93c237c9 44acd648920bfec9ced324b42b536402f8ea18cd 881e84d732c507992a65b6506015ee2dc5920f6c 63d128d26a251b252b7e6885b8f20f71f4b114c3 e978715cbf44b6d5b8c37cc4bdb411c9ccde47f0 60da302c59f41a857d6d365ce4fe04165509b042 6fdb86d5f3cc364f325f3ec2ae7b8aa6d9e31aed
# Create a new branch with these backported commits.
git checkout -b backport-848-to-v16.1-branch
# Push it to GitHub.
git push --set-upstream origin backport-848-to-v16.1-branch
# Go back to the original working tree.
cd ../..
# Delete the working tree.
git worktree remove .worktrees/backport

Then, create a pull request where the base branch is v16.1-branch and the compare/head branch is backport-848-to-v16.1-branch.

@mikelittle mikelittle mentioned this pull request Feb 8, 2024
@mikelittle mikelittle restored the update-v16.1 branch February 8, 2024 15:50
@mikelittle mikelittle deleted the update-v16.1 branch February 8, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants