Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warning: Use of undefined constant HM_ENV_REGION #31

Closed
fklein-lu opened this issue May 23, 2019 · 4 comments · Fixed by #40
Closed

Warning: Use of undefined constant HM_ENV_REGION #31

fklein-lu opened this issue May 23, 2019 · 4 comments · Fixed by #40
Assignees
@joehoyle
Labels
bug Existing functionality isn't behaving as expected

Comments

@fklein-lu
Copy link

Needs a defined() check: https://github.com/humanmade/altis-core/blob/master/inc/namespace.php#L130
@fklein-lu fklein-lu added the bug Existing functionality isn't behaving as expected label May 23, 2019
@roborourke
Copy link
Contributor

@joehoyle any thoughts on the ideal way to set this for local envs? Could default to us-east-1, or a string like not-needed as set in the local-server module for S3 Uploads.

@joehoyle
Copy link
Member

Yeah anything like that is fine, I think the env module (chassis I guess in this case) though we responsible for setting that.

@joehoyle joehoyle added this to the 2.0 Beta milestone May 27, 2019
@roborourke
Copy link
Contributor

@joehoyle it doesn't look like it's set anywhere in local-server either. I'll add issues to both of those repos.

This was referenced May 27, 2019
Closed
Closed
joehoyle added a commit that referenced this issue Jul 5, 2019
@joehoyle
Allow AWS SDK to be configured via altis configuration json.
24cbe1e 
Rather than relying on the constants to be defined, we should move the AWS config to the core module's configuration.

Fixes #31.
@joehoyle joehoyle mentioned this issue Jul 5, 2019
Merged
@joehoyle
Copy link
Member

joehoyle commented Jul 5, 2019

@roborourke rather than this approach, I ended up taking a different route in #40 which I think is a lot more natural, and means we don't need to define this constant in the local servers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joehoyle joehoyle

Labels
bug Existing functionality isn't behaving as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow AWS SDK to be configured via altis configuration json. humanmade/altis-core
3 participants
@roborourke @joehoyle @fklein-lu