Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codeception command enhancements #24

Merged
merged 3 commits into from
Jan 13, 2022
Merged

Codeception command enhancements #24

merged 3 commits into from
Jan 13, 2022

Conversation

roborourke
Copy link
Contributor

Fixes a couple of things I noticed, see what you think:

  • Decouple unlinking .test-running file from shutdown hook for removing the test db
  • Use canonical application name server instead of local-server
  • Only create and register shutdown hooks for db and browser once when iterating over suites

Copy link
Contributor

@shadyvb shadyvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shadyvb shadyvb merged commit 4944b00 into master Jan 13, 2022
@shadyvb shadyvb deleted the split-tmp-file-handling branch January 13, 2022 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants