Restart cavalcade on failure #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![hm-linter[bot]](https://avatars.githubusercontent.com/in/5455?s=60&v=4){kind=small}
roborourke
added
backport v1-branch
bug
rmccue
approved these changes
Nov 22, 2019
|
@rmccue that's not an available option, but presumably if there's some PHP error or whatever it should come back up. Guessing we do that on our infra? |
|
On the infra, I believe it will retry ~5 times; it also retries again (5 times) when you deploy. |
|
I'll see what we can do in future but right now I can't find another way to ensure the service is available after the initial install. |
roborourke
added a commit
that referenced
this pull request
Nov 25, 2019
Backport #81: Restart cavalcade on failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the server is ready before WP is installed the runner starts and finds the table doesn't exist then promptly exits and stops the container. Not ideal!