Update Smart Media for WP 6.0+ compatiblity #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The smart media image editing UI and functionality has been broken since WP 6.0 / Altis v13. This update restores that functionality and also fixes an incompatilbity with WP 6.4 whereby cropped image sizes were not present on the frontend srcset, also the width and height attributes were derived incorrectly. See humanmade/smart-media#219
mikelittle
approved these changes
Apr 2, 2024
This was referenced Apr 2, 2024
|
@mikelittle thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The smart media image editing UI and functionality has been broken since WP 6.0 / Altis v13.
This update restores that functionality and also fixes an incompatilbity with WP 6.4 whereby cropped image sizes were not present on the frontend srcset, also the width and height attributes were derived incorrectly.
The backport is safe as a patch release here even though it's bumping the minor version because the updates are all backwards compatible with WP 6.0+/Altis v13.
See humanmade/smart-media#219