JS Linting #41
Merged
JS Linting #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnbillion
approved these changes
Jan 26, 2021
| "jsdoc/require-returns": "off", | ||
| "no-unused-vars": "off", | ||
| "no-use-before-define": "off" | ||
| }, |
There was a problem hiding this comment.
You might be interested to know that I was making at attempt to not put any rule overrides in place, mostly to see whether it was practical or possible. I'm always concerned when I open a project and there are a hundred rule overrides and they only affect coding style. These all look like they make sense though.
There was a problem hiding this comment.
These are all sort-of required/recommended, since you are using TypeScript. There is even official documentation around this, but I would have to search for it.
But yeah, I agree that lots of overrides/disable statements is not a good sign.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR targets JavaScript-specific linting improvements or changes to be made that have been mentioned in #38.
In more detail, these include:
This PR conflicts with #42 in that both make changes to the
package.jsonfile. If you want to merge both PRs, you should be able to manually accept all changes—make sure to keep the most recent package version. If you do not or only partially merge this PR, you will have to adapt some JavaScritp/TypeScript code! This PR currently fails on CI because it does not fix any linting errors in the production code. This is done in #42.