-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JS Code Review #42
Merged
Merged
JS Code Review #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
Thanks for this Thorsten, this is very helpful and I agree with all the changes 👍 . I'll respond to your questions in #38 after I've finished checking the other PRs. |
johnbillion
approved these changes
Jan 26, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR targets JavaScript-specific code improvements or changes to be made that have been mentioned in #38.
In more detail, these include:
arrayMove
function to dedicated folder and file.SortableMultiValueElement
component to dedicated file.wp
global.ReactElement
type instead ofJSX.Element
.This PR conflicts with #41 in that both make changes to the
package.json
file. If you want to merge both PRs, you should be able to manually accept all changes—make sure to keep the most recent package version. If you do not or only partially merge this PR, you will have to adapt some JavaScript/TypeScript tooling configuration! This PR would currently fail on CI—iff ESLint would get executed—because it does not include linting configuration changes the production code assumes to exist. This is done in #41.