Prevent redirects when query string changes but cache key is the same #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes `redirect_canonical()` will recreate the query string and reformat it in the process. The end URL and result will be the same but the URLs do no match and so a redirect occurs. If Batcache caches this redirect then it will get the same cache key for URL formatted by `redirect_canonical()` and go into an endless redirect loop. This change resolves the problem by preventing a redirect in the case described.
![hm-linter[bot]](https://avatars.githubusercontent.com/in/5455?s=60&v=4){kind=small}
|
Fixing this upstream in Altis CMS instead, additionally going to fix in WP core per https://core.trac.wordpress.org/ticket/41712 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes
redirect_canonical()will recreate the query string and reformat it in the process. The end URL and result will be the same but the URLs do no match and so a redirect occurs. If Batcache caches this redirect then it will get the same cache key for URL formatted byredirect_canonical()and go into an endless redirect loop.This change resolves the problem by preventing a redirect in the case described.