Stylelint: Define function-url-quotes
#103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should this be added to the style guide as well? |
|
Yes, it and #104 should both be updated in the guides. I'll add PRs for those as well. |
rmccue
requested changes
Nov 16, 2018
peterwilsoncc
approved these changes
Dec 2, 2018
rmccue
approved these changes
Dec 3, 2018
There was a problem hiding this comment.
Added to Handbook, so we can proceed whenever you're ready here. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stylelint is currently (via a parent config, I assume) requiring that no quotes be used within the CSS
url()function. However, usingurl()without quotes requires special escaping and the potential for forgetting to escape a special character exists, making use with quotes just a little bit safer. I propose that we require quotes in URLs for consistency and ease of use.Ref: https://drafts.csswg.org/css-values-3/#urls
This PR defines this rule to "always" to match the current spec.