Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NamespaceDirectoryNameSniff for tests directory length #140

Merged
merged 8 commits into from
Jun 3, 2019

Conversation

mikeselander
Copy link
Contributor

Fixes #134

  • Adds tests for the tests directory that prove the initial failure
  • Fixes the code parsing for the incorrect directory length that triggered the Directory ts for namespace error

@mikeselander mikeselander requested a review from rmccue May 30, 2019 16:32
@mikeselander
Copy link
Contributor Author

I simplified the logic above and modified the regex to look for the last available instance of inc or tests in cases (like our test files) where there are two. I expect our tests are the only case this happens but it felt worth covering the case.

@mikeselander mikeselander merged commit 44dd6b9 into master Jun 3, 2019
@mikeselander mikeselander deleted the fix-tests-for-tests-directory branch June 3, 2019 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests/ not correctly exempt from HM.Files.NamespaceDirectoryName
3 participants