Update README to reflect updated .eslintrc location #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ability was removed in #54 without any documentation changes
tfrommen
approved these changes
Aug 6, 2018
|
Merging is blocked as there are PHPUnit failures on the |
rmccue
approved these changes
Aug 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the root-level README documentation around usage of ESLint. The existing README referenced an incorrect path to the project's
.eslintrcfile, which was removed from the root directory in #54. #54 also removed the ability to run ESLint via phpcs (it is preferable to run eslint directly via npm packages, or to use linter-bot).This PR updates the documentation around how to reference the
.eslintrcfile (renamed from.eslintrc.ymlin #40) if you choose to use the configuration from the composer package in lieu of installing directly via npm.Thank you @mattheu for raising this issue