Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix redirect_to support #18

Merged
merged 1 commit into from
Dec 1, 2020
Merged

Fix redirect_to support #18

merged 1 commit into from
Dec 1, 2020

Conversation

joehoyle
Copy link
Member

In https://github.com/humanmade/delegated-oauth2/pull/17/files we wrongly added the redirect_to param to the authroize URL, rather than the callback reidrect_uri in the authorize url.

In https://github.com/humanmade/delegated-oauth2/pull/17/files we wrongly added the redirect_to param to the authroize URL, rather than the callback reidrect_uri _in_ the authorize url.
Copy link

@hm-linter hm-linter bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linting failed (5 errors).

5 notices occurred in your codebase, but none on files/lines included in this PR.

@joehoyle joehoyle requested a review from rmccue November 30, 2020 21:17
@joehoyle
Copy link
Member Author

OK end to end tested this time!

@joehoyle joehoyle merged commit 311db8c into master Dec 1, 2020
@joehoyle joehoyle deleted the fix-redirect-ro branch December 1, 2020 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants