I18n support #47
Merged
I18n support #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abhishek Kaushik <abhishek@humanmade.com>
Signed-off-by: Abhishek Kaushik <abhishek@humanmade.com>
mattheu
requested changes
Aug 12, 2019
There was a problem hiding this comment.
Thanks for doing this @abhishek-kaushik - i left 2 comments.
Signed-off-by: Abhishek Kaushik <abhishek@humanmade.com>
Signed-off-by: Abhishek Kaushik <abhishek@humanmade.com>
|
I have changed text-domain to |
|
I'm not sure i'm afraid - I can't see why this is not working! |
|
I'll have a look today |
|
@mattheu So I tracked the issue down to the following error: I've let @abhishek-kaushik know the issue and he's going to go and update accordingly. |
Signed-off-by: Abhishek Kaushik <abhishek@humanmade.com>
| }; | ||
| constructor( props ) { | ||
| super( props ); | ||
| this.state = { |
There was a problem hiding this comment.
@abhishek-kaushik just being picky, add a blank line above.
Signed-off-by: Abhishek Kaushik <abhishek@humanmade.com>
There was a problem hiding this comment.
@mattheu Can you also scan over the changes proposed in this PR. Everything looks good from my end.
mattheu
approved these changes
Aug 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Support for translations and updated vulnerable packages.