Add 'switch' behavior for single-post-max #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
maxPosts: 1, the post-selection behavior isn't intuitive: Once a single post has been selected, the user must manually de-select that post before switching to another. This makes sense for multiple selections, for for a single selection it might make more sense that the current selection is switched to whatever post is clicked, without require de-selection first. This PR implements that change.This would change the behavior someone familiar with this package would expect, which may constitute a breaking change.
Note: This feature was added to a fork of this plugin used in another project, so I'm pushing it back upstream.