Add automatic flushing of rewrites #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows using manually to flush rewrites. This is handy if you want to add extra features (such as locking) but still use the hooks and better flushing system.
|
@joehoyle #reviewmerge Also, thoughts on changing |
|
Nice! Let's leave it experimentally disabled by default for now. I'll be turning this on fo sho |
joehoyle
added a commit
that referenced
this pull request
Aug 22, 2014
Add automatic flushing of rewrites
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This automatically flushes rewrite rules when they need to be. It does this by "generating" them on every request, which could potentially theoretically be slow.
In practice, the slowest part of rewrite rules is deleting the option, and then saving it again, which WP does every time you call
flush_rewrite_rules. If your rewrites haven't changed, deleting the option is unnecessary, asupdate_optioncan work out whether it needs to actually update the DB/object cache.This PR automatically flushes rewrite rules for you, if you define
HM_REWRITE_AUTOFLUSHas true. This currently defaults to false for backwards compatibility reasons, but setting it to true would be my preferred option.My findings in practice: there are 179 rules in use on Happytables. This adds ~3ms to page loads, which is negligible at best.