Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Stylelint to Linter Bot #80

Closed
mikeselander opened this issue Nov 24, 2018 · 5 comments · Fixed by #128
Closed

Add Stylelint to Linter Bot #80

mikeselander opened this issue Nov 24, 2018 · 5 comments · Fixed by #128

Comments

@mikeselander
Copy link
Contributor

We will shortly have Stylelint standards published to NPM as a package and it would be incredible useful from a reviewer's perspective to be able to run Stylelint in Linter Bot to evaluate both CSS and SCSS.

This will involve adding Stylelint evaluation of .stylelintrc and .stylelinignore files, pulling Stylelint core in, and (once published) our Styleling standards being applied by default.

My only concern with adding a whole new linter into Linter Bot is that it could immediately spam repos that Linter Bot is on with hundreds of CSS issues if we turn it on by default to start with.

To alleviate the above issue, I propose that we add Stylelint in a turned-off state by default. Projects can chose when to turn on Stylelint to use on their codebase and have a period of opportunity to fix their codebase before Linter Bot starts spitting out errors.

Then, after ~ 6 months with ratcheting notice given internally, we turn on Stylelint by default and each project can have the opportunity to turn Linter Bot off.

Any thoughts/issues @rmccue?

@jay-oswald
Copy link

Hey @mikeselander is there any chance that this will be happening?

@mikeselander
Copy link
Contributor Author

@jay-oswald yes, this will definitely be happening but it's a bit of an as-I-get-time task, so I wouldn't expect it for at least another month or two.

@rmccue
Copy link
Member

rmccue commented May 6, 2019

psst, if you'd like to get this earlier, feel free to send a PR! 😃

@jay-oswald
Copy link

@mikeselander good to hear! also @rmccue I would love to, but don't have time at work, and getting married at the end of the year, planning a wedding takes so much longer than it should haha

@rmccue
Copy link
Member

rmccue commented May 7, 2019

@jay-oswald Congratulations! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants