Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use std::shared_ptr, fix #218 #266

Merged
merged 1 commit into from Mar 2, 2022
Merged

use std::shared_ptr, fix #218 #266

merged 1 commit into from Mar 2, 2022

Conversation

nim65s
Copy link
Member

@nim65s nim65s commented Mar 1, 2022

No description provided.

jcarpent
jcarpent approved these changes Mar 1, 2022
View reviewed changes
Copy link
Member

@jcarpent jcarpent left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we enforce the use of the std namespace?

@jcarpent jcarpent merged commit 478b349 into humanoid-path-planner:devel Mar 2, 2022
@nim65s
Copy link
Member Author

nim65s commented Mar 4, 2022

Should we enforce the use of the std namespace?

I am not sure about what you mean.
If you mean "using all the std namespace", I think this is not a good idea
If you mean "forbidding boost::shared_ptr", I think this is a good idea, but I don't see how we could do that

@nim65s nim65s deleted the topic/std-shared-ptr branch September 27, 2022 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcarpent jcarpent jcarpent approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nim65s @jcarpent