Zero warnings #282
Merged
Zero warnings #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To fix remaining warnings from auto-doc. This change depends on ros/rosdistro#32683 - will uncomment once the rosdep key has been merged.
jcarpent
approved these changes
Apr 8, 2022
jcarpent
reviewed
Apr 8, 2022
|
@wxmerkt Do you know when ros/rosdistro#32683 will be merged? |
I'm afraid I don't :-( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should get us to zero warnings with gcc and clang.
Once ros/rosdistro#32683 is merged, we can uncomment the new dependency on pylatexenc in the package.xml and fix the unstable builds on the buildfarm (to remove the multi-line comment warnings and get nicer Python documentation strings in the bindings).