Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose shared_ptr<OcTree> #314

Merged
merged 1 commit into from Jun 29, 2022
Merged

Conversation

Jiayuan-Gu
Copy link
Contributor

Add shared_ptr<OcTree>, otherwise there will be No to_python (by-value) converter found for C++ type error for python binding makeOcTree

@nim65s
Copy link
Member

nim65s commented Jun 28, 2022

Thanks !

Could you add a simple regression test, reproducing this No to_python (by-value) converter found for C++ type error without your fix ?

@Jiayuan-Gu
Copy link
Contributor Author

Em, I guess you need an example to reproduce. Here is a simple script to reproduce.

Install hpp-fcl=2.0.1

conda create -n test-hpp-fcl python=3.8
conda install hpp-fcl=2.0.1 -c conda-forge

And run

import hppfcl as fcl
import numpy as np
fcl.makeOctree(np.random.rand(5, 3), 0.001)

@jcarpent
Copy link
Member

This PR looks good to me, as all other FCL primitives already use shared_ptr as Python container. Thanks @Jiayuan-Gu, your help is really appreciated.

@jcarpent jcarpent merged commit 8aed65f into humanoid-path-planner:devel Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants