This repository has been archived by the owner on Oct 26, 2022. It is now read-only.
typescript migration #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makarofalex3
changed the title
vkomodey
suggested changes
Jun 7, 2022
src/theme.tsx
Outdated
Comment on lines
9
to
11
| // TO-DO delete theme dont have this values | ||
| // mediumLight: '#ba68c8', | ||
| // white: '#f5f5f5' |
There was a problem hiding this comment.
why not delete it right now?
src/utils/index.ts
Outdated
| @@ -3,7 +3,7 @@ | |||
| * @param {*} escrowFactories Array of escrow Factories | |||
| * @returns the total count of factory | |||
| */ | |||
| export const countEscrowFactory = (escrowFactories) => { | |||
| export const countEscrowFactory = (escrowFactories: Array<any>) => { | |||
There was a problem hiding this comment.
Let's add a type here. Would be easier to understand, what this function is doing actually
|
What about running instructions(both local and remote)? Are they the same as were before? |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
started typescript migration