Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] [Typescript] Implement gas price multiplier #1265

Merged
merged 1 commit into from
Nov 24, 2023
Merged

Conversation

leric7
Copy link
Collaborator

@leric7 leric7 commented Nov 24, 2023

Description

Sometimes, gas estimation is too low, and on-chain txn are stuck from Typescript SDK.
Adding gas price multiplier to SDK build, so that it can increase/decrease gas price accordingly.

Summary of changes

  • Implemented new class BaseEthersClient, which has common functions of other clients.
  • Modified on-chain write calls to override gas price, if multiplier is specified.
  • Updated docs, and test cases.

How test the changes

Related issues

Keywords for linking issues

Close #1250

@leric7 leric7 requested a review from portuu3 November 24, 2023 12:29
Copy link

vercel bot commented Nov 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

9 Ignored Deployments
Name Status Preview Updated (UTC)
escrow-dashboard ⬜️ Ignored (Inspect) Nov 24, 2023 0:29am
faucet-server ⬜️ Ignored (Inspect) Nov 24, 2023 0:29am
hufi-exchange-oracle-server ⬜️ Ignored (Inspect) Nov 24, 2023 0:29am
hufi-job-launcher-server ⬜️ Ignored (Inspect) Nov 24, 2023 0:29am
hufi-recording-oracle-server ⬜️ Ignored (Inspect) Nov 24, 2023 0:29am
hufi-reputation-oracle ⬜️ Ignored (Inspect) Nov 24, 2023 0:29am
job-launcher-client ⬜️ Ignored (Inspect) Nov 24, 2023 0:29am
job-launcher-server ⬜️ Ignored (Inspect) Nov 24, 2023 0:29am
reputation-oracle-server ⬜️ Ignored (Inspect) Nov 24, 2023 0:29am

@leric7 leric7 merged commit 8c2ea3f into develop Nov 24, 2023
22 checks passed
@leric7 leric7 deleted the eric/sdk-gas-price branch November 24, 2023 13:45
@leric7 leric7 linked an issue Nov 24, 2023 that may be closed by this pull request
portuu3 pushed a commit that referenced this pull request Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SDK [Typescript] - Add gas price multiiplier
2 participants