Resolve Certik v3 Reports #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Ignored Deployments
|
mrhouzlane
suggested changes
May 4, 2023
mrhouzlane
reviewed
May 5, 2023
mrhouzlane
reviewed
May 5, 2023
mrhouzlane
reviewed
May 5, 2023
mrhouzlane
reviewed
May 5, 2023
mrhouzlane
suggested changes
May 5, 2023
|
Besides @dev tag this looks good to me. |
portuu3
requested changes
May 5, 2023
mrhouzlane
previously requested changes
May 5, 2023
vercel
bot
temporarily deployed
to
Preview – fortune-exchange-oracle-server
portuu3
previously approved these changes
May 5, 2023
vercel
bot
temporarily deployed
to
Preview – fortune-exchange-oracle-server
vercel
bot
temporarily deployed
to
Preview – fortune-exchange-oracle-server
portuu3
approved these changes
May 5, 2023
leric7
added a commit
that referenced
this pull request
May 5, 2023
* fix unnecessary math utils, and add comments to bulkPayout function * update doc and add missing require for amount in bulkpayout * use modifier * fix test
mrhouzlane
reviewed
May 8, 2023
| @@ -182,8 +180,21 @@ contract Escrow is IEscrow, ReentrancyGuard { | |||
| } | |||
|
|
|||
| /** | |||
| * @dev Bulk payout workers | |||
| * Should fail if any of the transaction is failing. | |||
| * @dev Performs bulk payout to multiple workers | |||
There was a problem hiding this comment.
This should stay @notice : Explain to an end user what this doe
@dev is the tag to : Explain to a developer any extra details
@notice : Performs bulk payout to multiple workers
@dev Escrow needs to be completed ...
I think certik wanted to have a clear comments :
- solc --devdoc --pretty-json Escrow.sol will return details with comments.
to check [https://coinsbench.com/natspec-the-right-way-to-comment-ethereum-smart-contracts-6762082252d4]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Certik v3 report is asking to write more comprehensive documentation about
bulkPayoutfunction for clarity.Summary of changes
SafeMathutils inHMToken.sol.bulkPayoutfunction ofEscrow.sol.How test the changes
Related issues
Keywords for linking issues
Closes #438
Operational checklist