fix: sdk staking client to add staker address when getting staker info #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
portuu3
requested changes
Jul 11, 2023
vercel
bot
temporarily deployed
to
Preview – fortune-exchange-oracle-server
vercel
bot
temporarily deployed
to
Preview – fortune-job-launcher-server
vercel
bot
temporarily deployed
to
Preview – fortune-job-launcher-client
vercel
bot
temporarily deployed
to
Preview – fortune-job-launcher-client
vercel
bot
temporarily deployed
to
Preview – fortune-job-launcher-server
vercel
bot
temporarily deployed
to
Preview – fortune-exchange-oracle-server
portuu3
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix Node.js/Python SDK
StakingClientmodule. It's missing address in the staker info, which is necessary.Summary of changes
getAllStakers, andgetStakerfunction of Node.js SDK, to includeaddressof the staker.get_staker_infofunction of Python SDK to includeaddressof the staker.stakertoaddressof the return value ofget_all_stakers_infofunction, to unify the response schema with Node.js SDK.How test the changes
Related issues
Keywords for linking issues
Closes #648
Operational checklist