Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK][Agreement] Add agreement package to sdk. #850

Merged
merged 3 commits into from
Sep 7, 2023

Conversation

simulacrum6
Copy link
Contributor

Description

This PR adds a submodule to the the python sdk for calculating Interrater Agreement.

Summary of changes

  • Copied source code from CVAT example to python sdk.
  • Copied tests from CVAT example to python sdk tests.
  • Added dependencies hypothesis (dev) and pyerf and numpy.

How test the changes

make unit-test

Related issues

Closes #777.

Operational checklist

  • All new functionality is covered by tests
  • Any related documentation has been changed or added

@simulacrum6 simulacrum6 added SDK IRA Package Issues related to the Inter-Rater Agreement package. labels Aug 30, 2023
@simulacrum6 simulacrum6 self-assigned this Aug 30, 2023
@vercel
Copy link

vercel bot commented Aug 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
escrow-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 5, 2023 9:47am
faucet-server ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 5, 2023 9:47am
fortune-exchange-oracle ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 5, 2023 9:47am
fortune-exchange-oracle-server ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 5, 2023 9:47am
fortune-job-launcher-client ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 5, 2023 9:47am
fortune-job-launcher-server ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 5, 2023 9:47am
fortune-recording-oracle ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 5, 2023 9:47am
fortune-reputation-oracle ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 5, 2023 9:47am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
job-launcher-server ⬜️ Ignored (Inspect) Visit Preview Sep 5, 2023 9:47am

@vercel vercel bot temporarily deployed to Preview – fortune-reputation-oracle August 30, 2023 10:22 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-job-launcher-client August 30, 2023 10:28 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-exchange-oracle-server August 30, 2023 10:30 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-job-launcher-server August 30, 2023 10:33 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-recording-oracle August 30, 2023 10:36 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-job-launcher-server August 30, 2023 15:06 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-recording-oracle August 30, 2023 15:06 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-reputation-oracle August 30, 2023 15:07 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-job-launcher-client August 30, 2023 15:08 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-exchange-oracle-server August 30, 2023 15:09 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-exchange-oracle August 30, 2023 15:11 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-recording-oracle September 5, 2023 09:43 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-exchange-oracle-server September 5, 2023 09:44 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-job-launcher-server September 5, 2023 09:46 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-exchange-oracle September 5, 2023 09:46 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-reputation-oracle September 5, 2023 09:47 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-job-launcher-client September 5, 2023 09:47 Inactive
@leric7
Copy link
Collaborator

leric7 commented Sep 5, 2023

I wonder if you have access to gitbook, but we'll need to update SDK docs.
In addition to, is this agreement module only limited to Python SDK? We don't want Typescript version of it?

@simulacrum6
Copy link
Contributor Author

simulacrum6 commented Sep 6, 2023

I wonder if you have access to gitbook, but we'll need to update SDK docs.

I can access the gitbook and make change requests. I suppose this is sufficient. Will make a change request and let you know once that is ready for review.

In addition to, is this agreement module only limited to Python SDK? We don't want Typescript version of it?

Currently it is only planned to be part of the python SDK. It is currently also only an optional extra module for the python SDK, to keep its size small.

Maybe I should add checks and appropriate warnings, if people try to import functions from the agreement package and they have not installed the required extras? At the moment, it will throw an import error, saying that required libraries are not installed.

Copy link
Contributor

@Dzeranov Dzeranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, let's wait for approval from @leric7

@simulacrum6 simulacrum6 merged commit 9283ae8 into develop Sep 7, 2023
17 checks passed
@simulacrum6 simulacrum6 deleted the feat/agreement/move-to-sdk branch September 7, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IRA Package Issues related to the Inter-Rater Agreement package. SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants