Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK][Typescript][Python] Add network array to getEscrows filter #913

Merged
merged 5 commits into from
Sep 22, 2023

Conversation

flopez7
Copy link
Contributor

@flopez7 flopez7 commented Sep 20, 2023

Description

Add network array to getEscrows filter to retrieve information from all networks

How test the changes

yarn test for Typescript and make run-test for Python

Operational checklist

  • All new functionality is covered by tests
  • Any related documentation has been changed or added

@flopez7 flopez7 self-assigned this Sep 20, 2023
@vercel
Copy link

vercel bot commented Sep 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
escrow-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 21, 2023 2:44pm
faucet-server ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 21, 2023 2:44pm
fortune-exchange-oracle ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 21, 2023 2:44pm
fortune-exchange-oracle-server ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 21, 2023 2:44pm
fortune-job-launcher-client ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 21, 2023 2:44pm
fortune-job-launcher-server ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 21, 2023 2:44pm
fortune-recording-oracle ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 21, 2023 2:44pm
fortune-reputation-oracle ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 21, 2023 2:44pm
job-launcher-client ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 21, 2023 2:44pm
job-launcher-server ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 21, 2023 2:44pm

leric7
leric7 previously requested changes Sep 20, 2023
Copy link
Collaborator

@leric7 leric7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have /examples directory for both Python/Typescript SDK. Let's update example, as well. This way, you can make sure your updates are working end-to-end. In addition, we need to update SDK docs on GitBook.

@flopez7
Copy link
Contributor Author

flopez7 commented Sep 21, 2023

We have /examples directory for both Python/Typescript SDK. Let's update example, as well. This way, you can make sure your updates are working end-to-end. In addition, we need to update SDK docs on GitBook.

@leric7 I have it in mind, I was waiting for the approval to update the documentation only once.

@vercel vercel bot temporarily deployed to Preview – fortune-reputation-oracle September 21, 2023 12:27 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-job-launcher-server September 21, 2023 12:27 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-job-launcher-client September 21, 2023 12:28 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-recording-oracle September 21, 2023 12:29 Inactive
@flopez7 flopez7 merged commit 1312716 into develop Sep 22, 2023
24 of 26 checks passed
@flopez7 flopez7 mentioned this pull request Sep 25, 2023
3 tasks
@flopez7 flopez7 deleted the feat/sdk/get-escrows-filter branch September 28, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants