Squashed 'pkg/lib/iscsi/' changes from 5c802c4..ce26141

ce26141 Merge pull request kubernetes-csi#40 from humblec/dep-update
46a11db update dependencies and go version
7f4f7cc Merge pull request kubernetes-csi#39 from humblec/new-changes
8566b12 iscsi library fixes based on the csi-driver-iscsi
c7bdbc5 Merge commit '706bbe0f1f5d43be335f2439f05fc15a8c372f32' into make-sync
0e71e17 Merge pull request kubernetes-csi#38 from humblec/new-1
676c6e5 Merge commit '67e5053588f954d534c3fae7f9d65116f0baee43' into make-sync
abf0d0a Correct the formatting issue in iscsiadm ListInterface
bb8cceb chore: fix gofmt
57f5817 add codespell linter to the github workflow actions
f6582f6 update: pick latest kube release for alpha version
366f319 Merge pull request kubernetes-csi#35 from humblec/rel-alpha1
83b78f5 Merge pull request kubernetes-csi#36 from humblec/owners
56f04a2 make sure the mountTargetDevice in the connector is non nil
30b6cf3 various linter corrections and code cleanup
83dec6e update OWNERS file
ad94dad correct codespell errors in the imported library

git-subtree-dir: pkg/lib/iscsi
git-subtree-split: ce2614163c72a5358a3f24e839ce55ff6f0a30c9

OWNERS

@@ -1,8 +1,16 @@
 # See the OWNERS docs: https://git.k8s.io/community/contributors/guide/owners.md
 
 approvers:
-- saad-ali
+- humblec
 - j-griffith
-reviews:
+- jsafrane
+- msau42
 - saad-ali
+- xing-yang
+reviewers:
+- humblec
 - j-griffith
+- jsafrane
+- msau42
+- saad-ali
+- xing-yang

README.md

@@ -29,8 +29,10 @@ issued.
 
 ## Intended Usage
 
-Curently the intended usage of this library is simply to provide a golang package to standardize how plugins are implementing
-iscsi connect and disconnect.  It's not intended to be  a "service", although that's a possible next step.  It's currenty been
+Currently, the intended usage of this library is simply to provide a golang
+package to standardize how plugins are implementing
+iscsi connect and disconnect.  It's not intended to be  a "service",
+although that's a possible next step.  It's currently been
 used for plugins where iscsid is installed in containers only, as well as designs where it uses the nodes iscsid.  Each of these
 approaches has their own pros and cons.  Currently, it's up to the plugin author to determine which model suits them best
 and to deploy their node plugin appropriately.

example/main.go

@@ -43,14 +43,14 @@ func main() {
 			SecretsType: "chap"},
 		// Lun is the lun number the devices uses for exports
 		Lun: int32(*lun),
-		// Number of times we check for device path, waiting for CheckInterval seconds inbetween each check (defaults to 10 if omitted)
+		// Number of times we check for device path, waiting for CheckInterval seconds in between each check (defaults to 10 if omitted)
 		RetryCount: 11,
-		// CheckInterval is the time in seconds to wait inbetween device path checks when logging in to a target
+		// CheckInterval is the time in seconds to wait in between device path checks when logging in to a target
 		CheckInterval: 1,
 	}
 
 	// Now we can just issue a connection request using our Connector
-	// A succesful connection will include the device path to access our iscsi volume
+	// A successful connection will include the device path to access our iscsi volume
 	path, err := c.Connect()
 	if err != nil {
 		log.Printf("Error returned from c.Connect: %s", err.Error())

go.mod

@@ -1,8 +1,15 @@
 module github.com/kubernetes-csi/csi-lib-iscsi
 
-go 1.15
+go 1.19
 
 require (
-	github.com/prashantv/gostub v1.0.0
-	github.com/stretchr/testify v1.7.0
+	github.com/prashantv/gostub v1.1.0
+	github.com/stretchr/testify v1.8.0
+)
+
+require (
+	github.com/davecgh/go-spew v1.1.1 // indirect
+	github.com/pmezard/go-difflib v1.0.0 // indirect
+	github.com/stretchr/objx v0.4.0 // indirect
+	gopkg.in/yaml.v3 v3.0.1 // indirect
 )

go.sum

@@ -1,13 +1,24 @@
 github.com/davecgh/go-spew v1.1.0 h1:ZDRjVQ15GmhC3fiQ8ni8+OwkZQO4DARzQgrnXU1Liz8=
 github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
+github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=
+github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
 github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM=
 github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
 github.com/prashantv/gostub v1.0.0 h1:wTzvgO04xSS3gHuz6Vhuo0/kvWelyJxwNS0IRBPAwGY=
 github.com/prashantv/gostub v1.0.0/go.mod h1:dP1v6T1QzyGJJKFocwAU0lSZKpfjstjH8TlhkEU0on0=
+github.com/prashantv/gostub v1.1.0 h1:BTyx3RfQjRHnUWaGF9oQos79AlQ5k8WNktv7VGvVH4g=
+github.com/prashantv/gostub v1.1.0/go.mod h1:A5zLQHz7ieHGG7is6LLXLz7I8+3LZzsrV0P1IAHhP5U=
 github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME=
+github.com/stretchr/objx v0.4.0 h1:M2gUjqZET1qApGOWNSnZ49BAIMX4F/1plDv3+l31EJ4=
+github.com/stretchr/objx v0.4.0/go.mod h1:YvHI0jy2hoMjB+UWwv71VJQ9isScKT/TqJzVSSt89Yw=
 github.com/stretchr/testify v1.7.0 h1:nwc3DEeHmmLAfoZucVR881uASk0Mfjw8xYJ99tb5CcY=
 github.com/stretchr/testify v1.7.0/go.mod h1:6Fq8oRcR53rry900zMqJjRRixrwX3KX962/h/Wwjteg=
+github.com/stretchr/testify v1.7.1/go.mod h1:6Fq8oRcR53rry900zMqJjRRixrwX3KX962/h/Wwjteg=
+github.com/stretchr/testify v1.8.0 h1:pSgiaMZlXftHpm5L7V1+rVB+AZJydKsMxsQBIJw4PKk=
+github.com/stretchr/testify v1.8.0/go.mod h1:yNjHg4UonilssWZ8iaSj1OCr/vHnekPRkoO+kdMU+MU=
 gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405 h1:yhCVgyC4o1eVCa2tZl7eS0r+SDo693bJlVdllGtEeKM=
 gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
 gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c h1:dUUwHk2QECo/6vqA44rthZ8ie2QXMNeKRTHCNY2nXvo=
 gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=
+gopkg.in/yaml.v3 v3.0.1 h1:fxVm/GzAzEWqLHuvctI91KS9hhNmmWOoWu0XTYJS7CA=
+gopkg.in/yaml.v3 v3.0.1/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=