Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

master: update release-tools + dependencies #39

Merged
merged 9 commits into from
Mar 23, 2021

Conversation

pohly
Copy link
Contributor

@pohly pohly commented Mar 18, 2021

Squashed 'release-tools/' changes from 7bc70e5..1748b16

1748b16 Merge pull request #136 from pohly/go-1.16
ec844ea remove travis.yml, Go 1.16
df76aba Merge pull request #134 from andyzhangx/add-build-arg
e314a56 add build-arg ARCH for building multi-arch images, e.g. ARG ARCH FROM k8s.gcr.io/build-image/debian-base-${ARCH}:v2.1.3

git-subtree-dir: release-tools
git-subtree-split: 1748b16b488381c34a86ddbee110e9ed523bcb20

updated runtime (Go 1.16) and dependencies

1748b16 Merge pull request kubernetes-csi#136 from pohly/go-1.16
ec844ea remove travis.yml, Go 1.16
df76aba Merge pull request kubernetes-csi#134 from andyzhangx/add-build-arg
e314a56 add build-arg ARCH for building multi-arch images, e.g. ARG ARCH FROM k8s.gcr.io/build-image/debian-base-${ARCH}:v2.1.3

git-subtree-dir: release-tools
git-subtree-split: 1748b16b488381c34a86ddbee110e9ed523bcb20
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 18, 2021
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 18, 2021
For example, this enables the use of the vendor
 directory by
default (https://golang.org/ref/mod#vendoring).
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 18, 2021
95eac33 Merge pull request kubernetes-csi#137 from pohly/fix-go-version-check
437e431 verify-go-version.sh: fix check after removal of travis.yml

git-subtree-dir: release-tools
git-subtree-split: 95eac33629ea9c586c4efcb7ad875191162464b2
@xing-yang
Copy link
Contributor

@pohly why do we get the Travis CI failure?

@pohly
Copy link
Contributor Author

pohly commented Mar 18, 2021

why do we get the Travis CI failure?

Because I removed the travis.yml from csi-release-tools. TravisCI wasn't supposed to be used anymore.

@pohly
Copy link
Contributor Author

pohly commented Mar 18, 2021

I can try removing the (now broken) link. Perhaps that will prevent TravisCI from doing anything with this repo.

csi-release-tools no longer has a travis.yml file because none of the
Kubernetes-CSI repos should be using it.
@xing-yang
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 18, 2021
@xing-yang
Copy link
Contributor

/assign @msau42

@msau42
Copy link
Collaborator

msau42 commented Mar 23, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42, pohly, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 23, 2021
@k8s-ci-robot k8s-ci-robot merged commit 4172954 into kubernetes-csi:master Mar 23, 2021
@pohly pohly deleted the prow-update-master branch March 23, 2021 18:35
humblec added a commit to humblec/csi-driver-iscsi that referenced this pull request Sep 5, 2022
7f4f7cc Merge pull request kubernetes-csi#39 from humblec/new-changes
8566b12 iscsi library fixes based on the csi-driver-iscsi
c7bdbc5 Merge commit '706bbe0f1f5d43be335f2439f05fc15a8c372f32' into make-sync
676c6e5 Merge commit '67e5053588f954d534c3fae7f9d65116f0baee43' into make-sync
bb8cceb chore: fix gofmt
57f5817 add codespell linter to the github workflow actions
f6582f6 update: pick latest kube release for alpha version
30b6cf3 various linter corrections and code cleanup
ad94dad correct codespell errors in the imported library

git-subtree-dir: pkg/lib/iscsi
git-subtree-split: 7f4f7cc2448e7181a5dec97b20acf5ec28c32c16
humblec added a commit to humblec/csi-driver-iscsi that referenced this pull request Sep 15, 2022
ce26141 Merge pull request kubernetes-csi#40 from humblec/dep-update
46a11db update dependencies and go version
7f4f7cc Merge pull request kubernetes-csi#39 from humblec/new-changes
8566b12 iscsi library fixes based on the csi-driver-iscsi
c7bdbc5 Merge commit '706bbe0f1f5d43be335f2439f05fc15a8c372f32' into make-sync
0e71e17 Merge pull request kubernetes-csi#38 from humblec/new-1
676c6e5 Merge commit '67e5053588f954d534c3fae7f9d65116f0baee43' into make-sync
abf0d0a Correct the formatting issue in iscsiadm ListInterface
bb8cceb chore: fix gofmt
57f5817 add codespell linter to the github workflow actions
f6582f6 update: pick latest kube release for alpha version
366f319 Merge pull request kubernetes-csi#35 from humblec/rel-alpha1
83b78f5 Merge pull request kubernetes-csi#36 from humblec/owners
56f04a2 make sure the mountTargetDevice in the connector is non nil
30b6cf3 various linter corrections and code cleanup
83dec6e update OWNERS file
ad94dad correct codespell errors in the imported library

git-subtree-dir: pkg/lib/iscsi
git-subtree-split: ce2614163c72a5358a3f24e839ce55ff6f0a30c9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants