Add support for CI in a Windows x64 environment. #232
Conversation
Note: I granted access to the repository for the Appveyor service so it will show up on future commits. Bit of a nuisance as it will be in a failing state right now, but let's see if this something useful. |
… reason on some builds)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 some minor comments
appveyor.yml
Outdated
|
||
test_script: | ||
- cd c:\projects\workspace | ||
- vendor/bin/phpunit -c phpunit.xml.dist |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing blank line
appveyor.yml
Outdated
php_ver_target: 7.1 | ||
|
||
cache: | ||
- '%LOCALAPPDATA%\Composer\files -> composer.lock' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to cache all of that? I though '%LOCALAPPDATA%\Composer\files'
was enough
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not strictly necessary to cache anything other than composer, but Humbug is the only project likely to benefit from Windows testing in the org, so we have cache to burn on PHP installs.
Damn, I was almost sure that Travis was missing in the checks. Silly Ubuntu scrollbars are too thin! I'd prefer to have styleci pushed to bottom as least critical. |
Could be worse. On Chrome on Mac, there are no scrollbars. It only shows when i try to scroll it. :P |
Would be cool if GitHub could group the pr and push statuses for the same service. |
@GrahamCampbell That would actually help. Of course, Travis could rebrand itself as APlusTravis or something and beat the alpha ordering ;). |
commit 9035df0 Author: Pádraic Brady <padraic.brady@gmail.com> Date: Mon Apr 24 22:04:07 2017 +0100 Use preset php target version commit aab1904 Author: Pádraic Brady <padraic.brady@gmail.com> Date: Mon Apr 24 21:56:15 2017 +0100 Make VC explicit commit bf75d60 Author: Pádraic Brady <padraic.brady@gmail.com> Date: Mon Apr 24 21:43:25 2017 +0100 Excl. 5.6 commit d31f302 Author: Pádraic Brady <padraic.brady@gmail.com> Date: Mon Apr 24 21:27:06 2017 +0100 Work from c:\tools\php, and initiate web client commit 8d79979 Author: Pádraic Brady <padraic.brady@gmail.com> Date: Mon Apr 24 21:13:24 2017 +0100 Install xdebug via powershell using appropriate versions
@humbug/core After tinkering (and a silly error on my part!), this should now be working. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some minor comments. 👍
|
||
environment: | ||
matrix: | ||
#- dependencies: lowest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add a comment linked to an issue or something here. Otherwise it's just a commented code/config we don't know if it can be removed or will be enabled later or something
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done with #235
return $path; | ||
} | ||
return sprintf('%s %s', $phpFinder->find(), $path); | ||
/* | ||
* Was: return sprintf('%s %s', $phpFinder->find(), $path); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure to understand that comment either
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mainly just a memory aid. I assume there was some Windows variant where this actually worked, so that does crop up as an issue, might save some time debugging. For now through, the php
command that was there really shouldn't be needed since the phpunit command is an executable script on Powershell.
Changes today:
@humbug/core Should be good to merge with one more review approval. |
Maybe @pamil has an idea about those Behat failures? In any case I believe they can be fixed later. I would just add an issue to not forget it :) |
Creates random fails on Appveyor where an update is not run
Implement Appveyor configuration
Implement Appveyor configuration
Appveyor is free to use, so long as we stay within the cache limits. I'm set this for an x64 env, assuming most people using PHP on Windows (don't cry!) have recent processors.
The initial run, assuming I haven't borked the configuration, is not passing with a few errors reported from PHPUnit.
Behat is not currently included in tests, but shouldn't be an issue to add later.