This repository has been archived by the owner on Mar 30, 2018. It is now read-only.
Basic PSR-2 error fixes from running phpcbf #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
StyleCI is failing due to trailing spaces |
|
Not sure about the AppVeyor failure though, looks weird |
|
StyleCI will fix more things if you enable more fixers. The "recommended" preset is very good, and can be tweaked if needed. |
|
There are a small number of fixers that go slightly beyond PSR-2, so couldn't be included in the preset, but can be used to enforce a slightly stricter version of PSR-2. |
|
@theofidry The Appveyor CI is pending #232 @GrahamCampbell The SyleCI interpretation of PSR2 is fine. If anything, I'd go in the other direction and exclude a sniff or two from phpcs where it goes over the standard. I don't think I can selectively add an additional one though (phpcs is not spotting all trailing whitespace as my last commit fixed). |
tabbabi
pushed a commit
to tabbabi/humbug
that referenced
this pull request
Aug 4, 2017
Merging as trivial
tabbabi
pushed a commit
to tabbabi/humbug
that referenced
this pull request
Aug 4, 2017
Merging as trivial
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds additional PSR-2 fixes from implementing #240. PHP CodeSniffer is stricter than StyleCI, but usually for fairly inconsequential things. This just cleans those up so using
composer cs-checkdoesn't explode.