User approval - default text is not transferred

[Semir1212]

HH 1.7.0

'Default content of approval emails' (Administration --> Users --> Settings) is not transferred to approval form which is displayed when an admin approves a user. Although the form is empty, the email is sent out with content.

Besides that the loginURL is displayed incorrectly in the email.

[fae7em]

Have you changed the default message in the setting form or it's generated by code? Because it suppose to be {loginLink} instead of {loginURL}.

humhub/protected/humhub/modules/admin/models/forms/ApproveUserForm.php

Lines 230 to 240 in a618cc1

	public static function getDefaultApprovalMessage($userDisplayName = '{displayName}', $adminDisplayName = '{AdminName}', $loginLink = '{loginLink}')
	{
	return Yii::t('AdminModule.user', "Hello {displayName},<br><br>\nYour account has been activated.<br><br>\n" .
	"Click here to login:<br>\n{loginLink}<br><br>\n\n" .
	"Kind Regards<br>\n{AdminName}<br><br>",
	[
	'{displayName}' => $userDisplayName,
	'{AdminName}' => $adminDisplayName,
	'{loginLink}' => $loginLink,
	]);
	}

[buddh4]

It seems I changed it in bc62148#diff-50786b2517fe78c0e6d6e2da1e1a20acb43afe83066ab033fd535e02eaa235a7 can we just replace both cases? I think the idea was to simplify the message text.

[buddh4]

So loginUrl = only url and loginLink is the rendered link, just as fallback for old texts.

[paviro]

I am also having this issue. Good tipp that it was changed to {loginLink}. To form is also empty for me on the sending screen.

[luke-]

A fix will be available with 1.7.1

#4631

[Cpt-KeksMonster]

Hello, is it possible this issue has returned in v1.11.1? I am experiencing the exact issue.

What steps will reproduce the problem?

Deny a user in Administration > "User Approval".

What is the expected result?

User gets an e-mail informing him, that he was not allowed to access this humhub instance.

What do you get instead?

An e-mail is send to the denied user telling him that he was approved.

Additional info

Q	A
HumHub version	1.11.1
PHP version	8.1

[luke-]

Can you please create a new issue for it?