Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer default content of user approve/decline email to approve/decline form #4630 #4631

Closed
wants to merge 2 commits into from

Conversation

fae7em
Copy link
Contributor

@fae7em fae7em commented Nov 13, 2020

Related to #4630
What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch if no hotfix
  • When resolving a specific issue, it's referenced in the PR's description (e.g. Fix #xxx[,#xxx], where "xxx" is the Github issue number)
  • All tests are passing
  • New/updated tests are included
  • Changelog was modified

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@fae7em fae7em changed the title Transfer default content of user approve/decline email to approve/dec… Transfer default content of user approve/decline email to approve/decline form #4630 Nov 13, 2020
@fae7em fae7em requested a review from buddh4 November 13, 2020 12:16
@fae7em fae7em self-assigned this Nov 13, 2020
@luke- luke- changed the base branch from develop to master November 23, 2020 09:08
@luke- luke- changed the base branch from master to develop November 23, 2020 09:09
@luke-
Copy link
Contributor

luke- commented Nov 23, 2020

@fae7em Can you please change the Base Branch to Master? This is a fix and should included with the next version.

@luke- luke- added the Kind:BUG label Nov 23, 2020
@fae7em
Copy link
Contributor Author

fae7em commented Nov 23, 2020

@fae7em Can you please change the Base Branch to Master? This is a fix and should included with the next version.

Here is the new pull request:
#4652

@luke-
Copy link
Contributor

luke- commented Nov 23, 2020

@fae7em Thanks for the quick action!

@luke- luke- closed this Nov 23, 2020
@luke- luke- deleted the fix/userApprovalDefaultMessage branch January 5, 2021 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants