Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the "Module Administration" page, remove "Show in Marketplace" for modules not in the @app/modules directory #6849

Open
marc-farre opened this issue Feb 8, 2024 · 4 comments

Comments

@marc-farre
Copy link
Collaborator

What steps will reproduce the problem?

Add a custom module to your HumHub instance.
Go to "Administration" -> "Module Administration".

image

What is the expected result?

View the module

What do you get instead?

image

Additional info

We should remove "Show in Marketplace" for custom modules that are not in the marketplace.

Q A
HumHub version 1.15
@luke-
Copy link
Contributor

luke- commented Feb 8, 2024

The reason behind this is that the 'Administration -> Modules' page should also work without a Marketplace API request, and should not be delayed by it.

Normally the folder protected/modules is for Marketplace Modules. Custom modules are preferably in other module folders.

We may be able to display the "Show in Marketplace" message only for modules from this folder.

@marc-farre
Copy link
Collaborator Author

So maybe we could create a protected/custom-modules directory in the source and add it to the moduleAutoloadPaths param, to avoid having to do it manually?
This way, sys-admins would see this directory and understand it's the place to add the custom modules.

@luke-
Copy link
Contributor

luke- commented Feb 8, 2024

Hmm, yes could be a solution. Maybe it would already be suffient to improve the docs here.

marc-farre added a commit to marc-farre/documentation that referenced this issue Feb 14, 2024
@marc-farre marc-farre changed the title In the "Module Administration" page, remove "Show in Marketplace" for modules not in the marketplace In the "Module Administration" page, remove "Show in Marketplace" for modules not in the @app/modules directory Feb 14, 2024
marc-farre added a commit that referenced this issue Feb 14, 2024
…tplace" for modules not in the @app/modules directory
marc-farre added a commit that referenced this issue Feb 14, 2024
…tplace" for modules not in the @app/modules directory
@marc-farre
Copy link
Collaborator Author

github-merge-queue bot pushed a commit that referenced this issue Feb 14, 2024
#6855)

* Fix #6849: In the "Module Administration" page, remove "Show in Marketplace" for modules not in the @app/modules directory

* Used configured Marketplace module path

---------

Co-authored-by: Lucas Bartholemy <lucas@bartholemy.com>
luke- added a commit to humhub/documentation that referenced this issue Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants