Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #6849: In the "Module Administration" page, remove "Show in Marke… #6855

Conversation

marc-farre
Copy link
Collaborator

…tplace" for modules not in the @app/modules directory

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch if no hotfix
  • When resolving a specific issue, it's referenced in the PR's description (e.g. Fix #xxx[,#xxx], where "xxx" is the Github issue number)
  • All tests are passing
  • New/updated tests are included
  • Changelog was modified

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Issue #6849

…tplace" for modules not in the @app/modules directory
Copy link

what-the-diff bot commented Feb 14, 2024

PR Summary

  • Update to the Development Change Log

    • There's a mention of a fix in the "Module Administration" page within our development change log file. Previously, the "Show in Marketplace" option was available for modules not included in a specific directory (@app/modules). Now, this option has been removed for those particular modules, providing a more streamlined and logical user experience.
  • Enhancement to InstalledModuleControls Function

    • A new condition has been introduced in the InstalledModuleControls.php file that checks if the path of the module matches the path of the marketplace modules. This helps to accurately place the "Show in Marketplace" link only for modules that reside in the right directory. This prevents any confusion that might result from displaying the link for modules out of the marketplace directory.

@luke- luke- added this pull request to the merge queue Feb 14, 2024
Merged via the queue into develop with commit 7ab0269 Feb 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants