New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enh: Add module manager test and add some improvements and bug fixes #6511
Conversation
While writing a test case to test the While registering modules, there is no test if the module is inheriting from
I would suggest to test for either that inheritance, or even better to create an interface that needs to be met (which is to be implemented by |
8236e29
to
fb7ff7f
Compare
Requested changes applied! @luke-, how would you like the CHANGELOG to be ammended? I guess it makes sense to have more than one line. Shall I create issues or add multiple lines with the same PR number, in order to document the separate the changes? |
@martin-rueegg As you like, but probably it is easier to add several lines with the same PR number. Is it sufficient for you if we merge this PR into v1.16? I would like to minimize changes to the current beta as little as possible. |
90d4553
to
7b721b0
Compare
7b721b0
to
71cb905
Compare
What kind of change does this PR introduce?
Please have a look at the commit titles to get an idea!
Does this PR introduce a breaking change?
ModuleManager
though.If yes, please describe the impact and migration path for existing applications:
ModuleManager
if they use a custom Manager in their setup or for the module itself.The PR fulfills these requirements:
develop
branch, not themaster
branch if no hotfixFix #xxx[,#xxx]
, where "xxx" is the Github issue number)Would it make sense to create different issues for documentation/tracking purposes?
Other information: