Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Module Manager test #6636

Merged
merged 5 commits into from Oct 29, 2023
Merged

Conversation

martin-rueegg
Copy link
Contributor

@martin-rueegg martin-rueegg commented Oct 28, 2023

What kind of change does this PR introduce? (check at least one)

  • Bugfix

Does this PR introduce a breaking change? (check one)

  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch if no hotfix
  • When resolving a specific issue, it's referenced in the PR's description (e.g. Fix #xxx[,#xxx], where "xxx" is the Github issue number)
  • All tests are passing
  • New/updated tests are included
  • Changelog was modified

@martin-rueegg
Copy link
Contributor Author

martin-rueegg commented Oct 28, 2023

@martin-rueegg martin-rueegg changed the title Fix/next module manager test Fix: Module Manager test Oct 28, 2023
@martin-rueegg
Copy link
Contributor Author

martin-rueegg commented Oct 28, 2023

@luke-

Thanks for you message regarding the failing tests.

The ones that failed before are now passing. However, there are other tests, that are not passing:

  • ProfileImageCest
  • PasswordRecoveryCest

I'm not quite sure, this is related and I'm having trouble to replicate this here on my local machine, as I often have many Cests here that fail, where they don't fail on github.

How shall we proceed? Do you have another test environment where you could test this branch?

@luke-
Copy link
Contributor

luke- commented Oct 28, 2023

@martin-rueegg Thanks for the fixes, currently there are problems with the selenium-chromedriver. I'll merge the fixes into next.

@luke- luke- merged commit ecd9c28 into humhub:next Oct 29, 2023
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants