Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for iPhone X #120

Merged
merged 14 commits into from
Dec 15, 2017
Merged

Support for iPhone X #120

merged 14 commits into from
Dec 15, 2017

Conversation

edencakir
Copy link
Contributor

Upgraded react-navigation since it already had JS implementation of SafeAreaView (react-native-safe-area-view).

Since we need transparent bars for some screens (Sidebar, QuickUpdate etc), most of the parts were updated manually, but it won't cause any issues when we upgrade the codebase to latest RN.

Manually updated paths:

  • src/screens/Feed/index.js
  • src/screens/Feed/pages/PostDetails.js
  • src/screens/Onboarding/common/OnboardingHeader/styles.js
  • src/screens/Profiles/components/SceneContainer/styles.js
  • src/screens/QuickUpdateScreen/styles.js
  • src/screens/Search/SearchScreen/styles.js
  • src/screens/Sidebar/SidebarScreen.js
  • src/screens/Sidebar/common/SidebarHeader.js
  • src/screens/Sidebar/styles.js

@edencakir edencakir changed the title Support for iPhone X 🚀 Support for iPhone X Dec 15, 2017
@JoshFabian JoshFabian merged commit b85566b into hummingbird-me:master Dec 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants