Provide content-length in the HTTPFields' literal when creating a response #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ponse This allows the HTTPFields to allocate sufficient room for `Content-Length`, `Server` and `Date`, preventing reallocs
|
The main issue was that contentl-length wasn't set yet, so the HTTPFields had a size of |
Joannis
commented
May 19, 2024
| import HTTPTypes | ||
|
|
||
| extension HTTPFields { | ||
| init(contentType: String, contentLength: Int) { |
There was a problem hiding this comment.
I wanted to centralize this as an internal helper, so that we can tweak the formula from here
…slower than expected
|
This is likely a great example of something that could use optimisation in HTTPFields |
|
This was already covered in PR #454 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the HTTPFields to allocate sufficient room for
Content-Length,ServerandDate, preventing reallocs