Minor optimisations #454
Merged
Minor optimisations #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joannis
reviewed
May 19, 2024
| let string = try self.encode(value) | ||
| var buffer = context.allocator.buffer(capacity: string.utf8.count) |
There was a problem hiding this comment.
Why not create the buffer from the string using NIO's helpers?
There was a problem hiding this comment.
No because that uses a temporary allocator and not the one that was attached to the Channel
| let data = try self.encode(value) | ||
| var buffer = context.allocator.buffer(capacity: data.count) |
There was a problem hiding this comment.
Can we use NIO's allocator helpers here
There was a problem hiding this comment.
No because that uses a temporary allocator and not the one that was attached to the Channel
There was a problem hiding this comment.
There was a problem hiding this comment.
Fair point. Will fix
Joannis
approved these changes
May 19, 2024
Co-authored-by: Joannis Orlandos <joannis@orlandos.nl>
This was referenced May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't allocate ByteBuffer before we know its size.
Provide contentLength when generating responses so header field size is not recalculated, when contentLength is added
Use
HTTPFields.containsinstead of subscript which constructs contents of HTTPField